Set pause, resume, restart to use requireAppNameAsArg #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeldwan
reviewed
Jun 26, 2020
There was a problem hiding this comment.
This looks good but requireAppNameAsArg duplicates requireAppName which has already been a bug hotspot. If we want a single init function to resolve the app we should combine them with some options to control which places to consider.
That aside, I think potentially destructive app subcommands are one place we don't want any inference. I swear there was a requireAppNameAsArg init function that did that 🤔.
|
Merging as is as all the initiators are in the mix for the command revision and the duplication will serve as a code smell. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.