Fix build on systems where sh is not bash #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When invoking `make` to build flyctl, I got the following error: scripts/generate_docs.sh: 6: [[: not found It looks like `scripts/generate_docs.sh` expects to run with bash, but the Makefile invokes it using `sh scripts/generate_docs.sh`. Change the Makefile to use `bash`, and also add a bash shebang to the script.
|
@joshtriplett nice fix, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When invoking
maketo build flyctl, I got the following error:scripts/generate_docs.sh: 6: [[: not found
It looks like
scripts/generate_docs.shexpects to run with bash, but theMakefile invokes it using
sh scripts/generate_docs.sh. Change theMakefile to use
bash, and also add a bash shebang to the script.