Add a --local-only flag to the flyctl deploy command #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeldwan
reviewed
Jul 15, 2020
| if op.RemoteOnly() { | ||
| commandContext.Status("flyctl", cmdctx.SINFO, "Remote-only set: performing remote build...") | ||
| } else { | ||
| commandContext.Status("flyctl", cmdctx.SINFO, "Docker daemon available: Still performing remote build...") |
There was a problem hiding this comment.
I think this line is unreachable since docker available and remote only false would use the branch on line 173.
There was a problem hiding this comment.
I pondered that and considered that it was possible if the remote/local flags lost their exclusion line in the deploy op. The fact that it doesn't flag unreachable leaves me tending to leave it there.
michaeldwan
approved these changes
Jul 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #237