Fix Pos() deadlock with file system invalidation #206
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a deadlock that occurs between
litefs.DB.mu
and the FUSE file system invalidation. Currently, the FUSE library is set to be synchronous so holding thelitefs.DB.mu
lock while committing to the journal and reading the-pos
file can cause a deadlock.The fix is to remove the
sync.Mutex
fromlitefs.DB
as it was no longer necessary because SQLite obtains locks for all the calls inside that alter data. Thelitefs.DB.pos
field has been converted to anatomic.Value
so that its value can be obtained independently of the SQLite locks. This is useful as a write transaction on the rollback journal would prevent inspection of the position.Originally reported by @kentcdodds in this Fly.io community forum post: https://community.fly.io/t/site-falls-over-every-few-hours-before-rebooting/8907/37