Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require explicit Consul key #237

Merged
merged 1 commit into from Dec 21, 2022
Merged

Require explicit Consul key #237

merged 1 commit into from Dec 21, 2022

Conversation

benbjohnson
Copy link
Collaborator

@benbjohnson benbjohnson commented Dec 21, 2022

This pull request removes the default Consul key as it is too easy to accidentally connect 2 clusters together if you're using the same Consul. This can have some very unexpected results.

Now, users will need to explicitly state the key they want to use for the cluster:

consul:
  url: "${FLY_CONSUL_URL}"
  key: "litefs/${FLY_APP_NAME}"
  advertise-url: "http://${HOSTNAME}.vm.${FLY_APP_NAME}.internal:20202"

Previously, the key was "litefs/primary" but it can be any value that is unique to your cluster (e.g. "production", "staging", etc). On Fly.io, Consul usage is scoped to an organization so it only need to be a unique key within your org.

@benbjohnson benbjohnson added this to the v0.3.0 milestone Dec 21, 2022
@benbjohnson benbjohnson merged commit 4570df1 into main Dec 21, 2022
@benbjohnson benbjohnson deleted the explicit-consul-key branch December 21, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant