Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for soft deleting databases. Previously, deleting a database would wipe it from the primary and then the primary would send a "drop db" frame to the replicas to have them delete as well.
However, this is problematic when connected to LiteFS Cloud (LFSC) for several reasons. First, LFSC acts as the data authority so when the primary removes the database, LiteFS detects that it exists on LFSC and downloads a snapshot, thus negating the delete. Second, LFSC aims to provide durability even in the face of accidental deletion so a delete should not remove old versions of the database.
Changes to LTX (superfly/ltx#46) were made to have a zero-length database represent a deletion. These changes have been integrated into LFSC and this PR integrates it into LiteFS.
/cc @gc-victor
Fixes #382
Usage