Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More understandable message #17

Merged
merged 2 commits into from
Sep 15, 2020
Merged

More understandable message #17

merged 2 commits into from
Sep 15, 2020

Conversation

shapkarin
Copy link
Contributor

No description provided.

venimus
venimus reviewed Sep 15, 2020
View reviewed changes
src/views/Home.vue Outdated Show resolved Hide resolved
venimus
venimus reviewed Sep 15, 2020
View reviewed changes
srv/index.js Outdated Show resolved Hide resolved
@venimus venimus merged commit 10c2c1c into master Sep 15, 2020
@venimus venimus deleted the jwt_message branch September 15, 2020 13:42
davidyuk
davidyuk reviewed Oct 8, 2020
View reviewed changes
Copy link
Member

@davidyuk davidyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is Superhero ID?

@shapkarin
Copy link
Contributor Author

What is Superhero ID?

@davidyuk That means superhero account. So I suggest to rename ID to the account.

@davidyuk
Copy link
Member

davidyuk commented Oct 9, 2020

And how superhero account connected to message signing? I won't agree that this PR made the message more understandable 🙃

@shapkarin
Copy link
Contributor Author

shapkarin commented Oct 9, 2020 •
edited
Loading

@davidyuk sure, it's just a suggestion. But I think that account is better than ID. the main goal is to make messages as much understandable as it can be. We need to find some balance between technical description and understand for non tech users. Lets discuss that, maybe at some issue,

@shapkarin shapkarin mentioned this pull request Oct 9, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidyuk davidyuk davidyuk left review comments

@venimus venimus venimus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shapkarin @davidyuk @venimus