New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow register of names with all characters allowed in names spec #2118

Closed

davidyuk opened this issue Jun 13, 2023 · 0 comments · Fixed by #3023

Member

davidyuk commented Jun 13, 2023

It's being worked on in #1671

I'm going to support it in the next release of SDK after merging aeternity/aepp-sdk-js#1840

Consider replacing
https://github.com/aeternity/superhero-wallet/blob/02f012500c1dca0593771b2cdcca820f99c891af/src/popup/utils/utils.ts#L240-L245
with isNameValid from SDK.

Also, ensure that fonts look correct when using Cyrillic chars or so in names.

The text was updated successfully, but these errors were encountered:

CedrikNikita mentioned this issue

refactor: use isNameValid from sdk instead of custom #3023

Merged

CedrikNikita closed this as completed in #3023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment