Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aens): support unicode names claim #1840

Merged
merged 5 commits into from Jun 17, 2023
Merged

Conversation

davidyuk
Copy link
Member

@davidyuk davidyuk commented Jun 13, 2023

closes #1726 #1539
partially #1580

URL class can encode emoji to punycode, but it is not supported in IDNA2008, so node not accepting these names.

This PR is supported by the Æternity Crypto Foundation

@davidyuk davidyuk force-pushed the feature/unicode-names branch 3 times, most recently from b4d53db to 355dea5 Compare June 13, 2023 10:35
@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Patch coverage: 78.34% and project coverage change: -0.25 ⚠️

Comparison is base (3653b13) 82.68% compared to head (f837e90) 82.44%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1840      +/-   ##
===========================================
- Coverage    82.68%   82.44%   -0.25%     
===========================================
  Files           91       93       +2     
  Lines         3119     3252     +133     
  Branches       617      648      +31     
===========================================
+ Hits          2579     2681     +102     
- Misses         249      265      +16     
- Partials       291      306      +15     
Impacted Files Coverage Δ
src/aens.ts 89.74% <ø> (ø)
src/chain.ts 87.05% <ø> (ø)
src/tx/builder/constants.ts 100.00% <ø> (ø)
src/Middleware.ts 67.64% <67.64%> (ø)
src/MiddlewareSubscriber.ts 70.27% <70.27%> (ø)
src/index-browser.ts 97.61% <94.11%> (-2.39%) ⬇️
src/channel/Base.ts 76.47% <100.00%> (ø)
src/deprecated.ts 50.00% <100.00%> (+10.00%) ⬆️
src/tx/builder/helpers.ts 87.87% <100.00%> (+8.80%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@davidyuk davidyuk added this to the v13.1.0 milestone Jun 13, 2023
@davidyuk davidyuk merged commit 7509795 into develop Jun 17, 2023
3 of 5 checks passed
@davidyuk davidyuk deleted the feature/unicode-names branch June 17, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support internationalized AENS names
1 participant