Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SuperTextField][Mobile] - Popover toolbar appears when it shouldn't #2005

Closed
matthew-carroll opened this issue May 16, 2024 · 2 comments · Fixed by #2019
Closed

[SuperTextField][Mobile] - Popover toolbar appears when it shouldn't #2005

matthew-carroll opened this issue May 16, 2024 · 2 comments · Fixed by #2019
Assignees
Labels
area_supertextfield Pertains to SuperTextField bounty_junior f:superlist Funded by Superlist time: 1 1hr or less type_bug Something isn't working

Comments

@matthew-carroll
Copy link
Contributor

Package Version
main

To Reproduce
Steps to reproduce the behavior:

  1. Tap on an empty SuperTextField on mobile

Minimal Reproduction Code
Run the SuperTextField demo

Actual behavior
A popover toolbar appears.

Expected behavior
No popover toolbar should appear because there isn't any content to interact with.

If iOS and Android show a similar behavior to what we have, then feel free to correct me, but this seems wrong.

Platform
Repro'd on iOS, but probably on Android, too.

Flutter version
v.3.22

Screenshots

Screen.Recording.2024-05-16.at.12.51.44.PM.mov
@matthew-carroll matthew-carroll added type_bug Something isn't working area_supertextfield Pertains to SuperTextField bounty_junior f:superlist Funded by Superlist time: 1 1hr or less labels May 16, 2024
@angelosilvestre
Copy link
Collaborator

@matthew-carroll I think the toolbar should be visible so the user can tap the "Paste" button. Should we just hide the "Cut" and "Copy" buttons when there isn't an expanded selection?

@matthew-carroll
Copy link
Contributor Author

@angelosilvestre can you check iOS and Android and check whether a toolbar appears the moment you place the caret or not? I don't think I remember ever seeing a toolbar upon first tap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area_supertextfield Pertains to SuperTextField bounty_junior f:superlist Funded by Superlist time: 1 1hr or less type_bug Something isn't working
Projects
None yet
2 participants