Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cursor at wrong position after portrait to landscape rotation #2056

Closed
knopp opened this issue May 28, 2024 · 0 comments · Fixed by #2057
Closed

Cursor at wrong position after portrait to landscape rotation #2056

knopp opened this issue May 28, 2024 · 0 comments · Fixed by #2057
Assignees
@angelosilvestre
Labels
area_super_reader Related to SuperReader area_supereditor Pertains to SuperEditor bounty_junior f:superlist Funded by Superlist platform_android Applies to use on Android platform_ios Applies to use on iOS time:2

Comments

@knopp
Copy link
Contributor

knopp commented May 28, 2024

cursor_position.mov

Seems like a regression caused by #1967

The problem is IosControlsDocumentLayerState accessing the RenderBox to get size inside computeLayoutDataWithDocumentLayout, but the way ContentLayers currently work, the computeLayoutDataWithDocumentLayout method is called during build, before the render box is laid out.

cc @angelosilvestre
@knopp knopp mentioned this issue May 28, 2024
Open
@matthew-carroll matthew-carroll added area_supereditor Pertains to SuperEditor platform_ios Applies to use on iOS platform_android Applies to use on Android bounty_junior f:superlist Funded by Superlist time:2 area_super_reader Related to SuperReader labels May 28, 2024
angelosilvestre added a commit that referenced this issue May 28, 2024
@angelosilvestre
[SuperEditor][Mobile] Fix caret position after rotation (Resolves #2056)
f96e2f9
@angelosilvestre angelosilvestre mentioned this issue May 29, 2024
Merged
matthew-carroll pushed a commit that referenced this issue Jun 7, 2024
@angelosilvestre
[SuperEditor][Mobile] Fix caret position after rotation (Resolves #2056…
a212a35 
…) (#2057)
github-actions bot pushed a commit that referenced this issue Jun 7, 2024
@angelosilvestre @web-flow
[SuperEditor][Mobile] Fix caret position after rotation (Resolves #2056…
d4821ba 
…) (#2057)
matthew-carroll pushed a commit that referenced this issue Jun 7, 2024
@angelosilvestre @matthew-carroll
[SuperEditor][Mobile] Fix caret position after rotation (Resolves #2056…
d85ec49 
…) (#2057)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@angelosilvestre angelosilvestre

Labels
area_super_reader Related to SuperReader area_supereditor Pertains to SuperEditor bounty_junior f:superlist Funded by Superlist platform_android Applies to use on Android platform_ios Applies to use on iOS time:2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[SuperEditor][Mobile] Fix caret position after rotation (Resolves #2056) superlistapp/super_editor
3 participants
@knopp @matthew-carroll @angelosilvestre