Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flutter_test_repo_test.sh doesn't fail on failure #728

Closed
Hixie opened this issue Aug 10, 2022 · 0 comments · Fixed by #732
Closed

flutter_test_repo_test.sh doesn't fail on failure #728

Hixie opened this issue Aug 10, 2022 · 0 comments · Fixed by #732
Assignees
@matthew-carroll
Labels
bounty_junior

Comments

@Hixie
Copy link

Hixie commented Aug 10, 2022

I have discovered a problem with https://github.com/superlistapp/super_editor/blob/main/flutter_test_registry/flutter_test_repo_test.sh
It doesn't actually fail when the tests fail! :-)
Probably the same is true with https://github.com/superlistapp/super_editor/blob/main/flutter_test_registry/flutter_test_repo_test.bat, but I'm not as familiar with batch files.

For the shell script, it can be solved by adding set -e at the top.
@matthew-carroll matthew-carroll self-assigned this Aug 12, 2022
matthew-carroll added a commit that referenced this issue Aug 12, 2022
@matthew-carroll
Updated Flutter test registry scripts to exit on failure (Resolves #728)
cea038f
@matthew-carroll matthew-carroll mentioned this issue Aug 12, 2022
Merged
matthew-carroll added a commit that referenced this issue Aug 13, 2022
@matthew-carroll
Updated Flutter test registry scripts to exit on failure (Resolves #728…
84bd321 
…) (#732)
@jason-simmons jason-simmons mentioned this issue Oct 4, 2022
Closed
dnfield added a commit to flutter/tests that referenced this issue Oct 19, 2022
@dnfield
Delete super_editor.test
8e85f7d 
These tests has never passed, and have historically suffered from superlistapp/super_editor#728

We should not have the run as part of the suite until they are passing.
@dnfield dnfield mentioned this issue Oct 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthew-carroll matthew-carroll

Labels
bounty_junior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated Flutter test registry scripts to exit on failure (Resolves #728) superlistapp/super_editor
2 participants
@Hixie @matthew-carroll