[attributed_text] Fix invalid end index with an marker that exceeds text length (Resolves #632) #1765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ext length (Resolves #632)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[attributed_text] Fix invalid end index with an marker that exceeds text length. Resolves #632
When an
AttributedTexthas aSpanMarkerwith an end index equals to the text length (which is an invalid index, because the spans are inclusive),collapseSpansreturns a span with an end index equal to the text length, instead of the text length -1, which is the expected index that would point to the last character.This PR fixes the comparison that causes this behavior.