Fixed bug with emojis and action tag reaction due to incorrect character movement across emojis (Resolves #1882) #1887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter movement across emojis (Resolves #1882)
|
Hey @matthew-carroll , your modification in TagFinder won't solve the whole issue with emojis. emoji-bug.mp4
Can you please consider reviewing my PR here, which solves both issues? Thank you :) |
Comment on lines
+69
to
+72
| while (nextCharacterOffset != null && nextCharacterOffset < rawText.length) { | ||
| if (nextCharacterOffset >= rawText.length) { | ||
| break; | ||
| } |
There was a problem hiding this comment.
Is this if statement necessary? We already check this in the while condition.
Comment on lines
+654
to
+656
| group("emojis >", () { | ||
| // Based on bug https://github.com/superlistapp/super_editor/issues/1882 | ||
| testWidgetsOnArbitraryDesktop("can appear at the beginning of text", (tester) async { |
There was a problem hiding this comment.
Does this test belongs to this file? It seems we don't do anything related to tags in this test.
|
I'm gonna close this in favor of #1879 where we'll attempt to review and merge a different fix for the same problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bug with emojis and action tag reaction due to incorrect character movement across emojis (Resolves #1882)
The issue was that the action tag reaction was assuming, in a couple places, that every character only occupies a single codepoint.