Revert "NonReparentingFocus - Reparent focus node in deactivate to match framework #1969
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 60bb442.
This causes some issues:
I think the reason for this is that
FocusState
from framework reparents itself to parent duringbuild()
for reasons not entirely clean to me. It's a fragile system and rolling custom focus widget seem to break some assumptions that rest of the framework does (i.e. related focus scope caching that was added recently).I think we should figure out whether
NonReparentingNode
is necessary at all in the presence ofOverlayPortal
and if not remove it completely.