[SuperEditor][Android] Show expanded handles when expanding the selection (Resolves #1937) #2014
Conversation
|
@angelosilvestre please post a video of the solution |
| if (widget.selection.value != null && | ||
| widget.selection.value?.isCollapsed == false && | ||
| _controlsController!.shouldShowCollapsedHandle.value == true) { | ||
| // The selection is expanded, but the collapsed handle is visible. This can happen when the |
There was a problem hiding this comment.
This reads like a bandaid - it says "here's a state that shouldn't happen, but does happen, so we'll correct it here".
Why is the wrong thing happening to begin with? Why is this the right place to correct it?
There was a problem hiding this comment.
Well, usually we show/hide the handles in the touch handlers of the interactor. A double tap shows the expanded handle, a single tap shows the collapsed handle, etc...
In this case the selection is changed elsewhere. So I think we should be changing the handle visibility when the selection changes.
There was a problem hiding this comment.
In this case the selection is changed elsewhere
Where is it being changed?
There was a problem hiding this comment.
@angelosilvestre did you see this question?
There was a problem hiding this comment.
@matthew-carroll I haven't noticed this, sorry.
The "Select All" button issues a ChangeSelectionRequest, this isn't initiated by one of our widgets.
expanded.webm |
|
@angelosilvestre this PR now has some conflicts after another PR was merged. Also, can you take a look at the failing website deployment actions? They seem to be failing in a number of PRs but I'm not sure why. |
angelosilvestre
force-pushed
the
1937_android-show-expanded-handles
branch
from
35b8412
to
92e60bc
Compare
|
@matthew-carroll I resolved the conflicts. The website build failure seems to be due to the |
| return; | ||
| } | ||
|
|
||
| if (selection.isCollapsed == true && |
There was a problem hiding this comment.
Is there a reason that you're doing == true and == false for a boolean value?
There was a problem hiding this comment.
Previously we were handling a nullable value and I forgot to update it. I updated it now.
[SuperEditor][Android] Show expanded handles when expanding the selection. Resolves #1937
When the selection changes from collapsed to expanded, the collapsed handle is visible at the beginning of the selection, and the expanded handles aren't visible:
collapsed.webm
This PR fixes the issue by changing the visibility of the handles when needed.