[SuperEditor] Add list item customization via stylesheet (Resolves #1912) #2017
Conversation
| @@ -189,6 +194,10 @@ class ListItemComponentViewModel extends SingleColumnLayoutComponentViewModel wi | |||
| required this.type, | |||
| this.ordinalValue, | |||
| required this.indent, | |||
| this.dotColor, | |||
There was a problem hiding this comment.
I'm noticing that these properties are the first situation where this view model doesn't apply equally to both types of list items. Looks like we should split this view model into two - one for ordered list items and one for unordered list items.
It might make sense to create a shared superclass that has everything but those dot and numeral styles.
| if (node.type == ListItemType.unordered) { | ||
| return UnorderedListItemComponentViewModel( | ||
| nodeId: node.id, | ||
| indent: node.indent, |
There was a problem hiding this comment.
Should we be initializing these with default dot and numeral choices?
There was a problem hiding this comment.
The constructor already have default values for that, so I think we could omit them.
| @@ -385,6 +534,10 @@ Widget _defaultUnorderedListItemDotBuilder(BuildContext context, UnorderedListIt | |||
| final attributions = component.text.getAllAttributionsAt(0).toSet(); | |||
| final textStyle = component.styleBuilder(attributions); | |||
|
|
|||
| final dotColor = component.dotStyle?.color ?? textStyle.color; | |||
There was a problem hiding this comment.
Is there any reason that these values aren't set inline within the widget tree? Do we need variables for them?
There was a problem hiding this comment.
For the dot size I think it makes sense because we need access both width and height. I removed the others.
[SuperEditor] Add list item customization via stylesheet. Resolves #1912
This PR adds the ability to customize list items using stylesheets.
Customization for unordered list items:
Customization for ordered list items:
For roman numbers, we support until 3999 and them switch to arabic. I tried the w3 playground in https://www.w3schools.com/css/tryit.asp?filename=trycss_list-style-type_ex and it seems that html lists also work like that.
CSS list style references: https://www.w3schools.com/css/css_list.asp