[SuperEditor][Mobile] Add caret customization (Resolves #1935) #2020
Conversation
| @@ -177,6 +177,13 @@ class TestSuperEditorConfigurator { | |||
| return this; | |||
| } | |||
|
|
|||
| /// Configures the [SuperEditor] to ignore the default layers and to use the given only | |||
There was a problem hiding this comment.
Looks like "the given" is repeated twice.
Also, this dart doc doesn't help me understand why this method exists, or when/why I might use it.
| @@ -177,6 +177,16 @@ class TestSuperEditorConfigurator { | |||
| return this; | |||
| } | |||
|
|
|||
| /// Configures the [SuperEditor] to use the given [documentLayers]. | |||
| /// | |||
| /// This can be used, for example, to customize the caret style for a specific platform. | |||
There was a problem hiding this comment.
This seems like a lot of responsibility to just change the caret style. Do we have similar examples of minor customizations that require this level of intervention?
I know we have keyboard handlers, but that situation is mostly about adding a few new handlers on top of existing ones.
In this case, the user is altering an existing UI property in a small way....
| @@ -578,13 +603,20 @@ class _TestSuperEditorState extends State<_TestSuperEditor> { | |||
| // iOS floating toolbar. | |||
| const SuperEditorIosToolbarFocalPointDocumentLayerBuilder(), | |||
| // Displays caret and drag handles, specifically for iOS. | |||
| const SuperEditorIosHandlesDocumentLayerBuilder(), | |||
| SuperEditorIosHandlesDocumentLayerBuilder( | |||
There was a problem hiding this comment.
What I was talking about in my layers comment was meant to go behind the specific place where custom layers were being created. I was also talking about how we expect app developers to customize these properties.
Am I reading this correctly that app developers will need to provide a custom list of layers to SuperEditor if they want a 3px wide caret instead of a 2px wide caret?
There was a problem hiding this comment.
Am I reading this correctly that app developers will need to provide a custom list of layers to SuperEditor if they want a 3px wide caret instead of a 2px wide caret?
Currently yes. We already have caret customization for desktop, which involves creating the whole list of layers...
[SuperEditor][Mobile] Add caret customization. Resolves #1935
This PR adds the following customizations: