Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SuperEditor] Convert empty task to paragraph on ENTER (Resolves #1898) #2034

Merged
merged 1 commit into from
May 25, 2024

Conversation

angelosilvestre
Copy link
Collaborator

[SuperEditor] Convert empty task to paragraph on ENTER. Resolves #1898

Pressing enter on an empty task isn't converting it to a paragraph. This is the default behavior for list items.

This PR change the new line handling, both with keyboard and deltas to convert empty list items to paragraphs.

Copy link
Contributor

@matthew-carroll matthew-carroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matthew-carroll matthew-carroll merged commit ec38a6d into main May 25, 2024
11 checks passed
@matthew-carroll matthew-carroll deleted the 1898_empty-task-to-paragraph branch May 25, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SuperEditor] Empty task doesn't get removed on pressing enter/return
2 participants