[SuperEditor][Android] Fix auto-scrolling start region (Resolves #2000) #2036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// If this widget doesn't have an ancestor `Scrollable`, then this | ||
| /// widget includes a `ScrollView` and this `State`'s render object | ||
| /// is the viewport `RenderBox`. | ||
| RenderBox get viewportBox => |
There was a problem hiding this comment.
We have similar mapping methods in other widgets. Is it usually declared above initState()?
There was a problem hiding this comment.
I checked and we declare below dispose. Updated.
matthew-carroll
pushed a commit
that referenced
this pull request
May 26, 2024
quaaantumdev
pushed a commit
to quaaantumdev/super_editor
that referenced
this pull request
Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[SuperEditor][Android] Fix auto-scrolling start region. Resolves #2000
On Android, the auto-scrolling only starts when the user drags near the top of the screen. This causes problems when there are widgets above the editor, like an
AppBar:before.webm
The reason is that we are not converting the
Offsetto the offset inside the viewport.This PR fixes the issue by converting the
Offset:after.webm