Changed linkification on paste to match URL parsing within the linkification reaction (Resolves #2031) #2045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ication reaction (Resolves #2031)
angelosilvestre
approved these changes
May 27, 2024
Comment on lines
1173
to
1174
| // Type text with two URLs | ||
| await tester.typeImeText("https://www.google.com and https://flutter.dev "); |
There was a problem hiding this comment.
Please end the comment with a dot.
| // Place the caret at the beginning of the empty document. | ||
| await tester.placeCaretInParagraph("1", 0); | ||
|
|
||
| // Paste text with a URL |
There was a problem hiding this comment.
Please end the comment with a dot.
| await tester.pressCtlV(); | ||
| } | ||
|
|
||
| // Ensure the URL is linkified |
There was a problem hiding this comment.
Please end the comment with a dot.
| // Place the caret at the beginning of the empty document. | ||
| await tester.placeCaretInParagraph("1", 0); | ||
|
|
||
| // Paste text with a URL |
There was a problem hiding this comment.
Please end the comment with a dot.
| await tester.pressCtlV(); | ||
| } | ||
|
|
||
| // Ensure the URL is linkified |
There was a problem hiding this comment.
Please end the comment with a dot.
quaaantumdev
pushed a commit
to quaaantumdev/super_editor
that referenced
this pull request
Jun 1, 2024
…ication reaction (Resolves superlistapp#2031) (superlistapp#2045)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed linkification on paste to match URL parsing within the linkification reaction (Resolves #2031)
Linkification when pasting content wasn't recognizing URLs without www and https. This is because we have two different linkification paths. One for pasting, which happens at the moment the text is pasted. Another for reacting to user input.
This PR alters the existing pasting behavior to match the link extraction of the linkification reaction.
I'd like to move linkification entirely into the reaction, but it's not completely clear how to determine whether or not the user pasted the content vs got it some other way. I filed a proposal to add such details to all changes: #2044
This PR solves the problem without doing a much larger refactor as described in that proposal.