-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add popover toolbar builder that uses Flutter's new support for an iOS 16+ system toolbar (Resolves #2032) #2058
base: main
Are you sure you want to change the base?
Conversation
…S 16+ system toolbar (Resolves #2032)
@BazinC - I added iOS system menu support to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a single comment.
|
||
/// An [IOSPopoverToolbarBuilder] that displays the iOS system popover toolbar, if the version of | ||
/// iOS is recent enough, otherwise builds [defaultIosPopoverToolbarBuilder]. | ||
Widget iOSSystemPopoverToolbarWithBackupFlutterVersion(BuildContext context, IOSEditingOverlayController controller) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is WithBackupFlutterVersion
an appropriate name? I think iOSSystemPopoverToolbarWithFallback
would be simpler.
@matthew-carroll We don't use SuperIOSText. Is this PR related to the following comment? #2032 (comment) |
@BazinC this PR adds the use of the native menu. It adds it to SuperTextField, first, because that's simpler. Can you please try out a SuperTextField on iOS and check if the native menu meets your expectations? If we need to make changes to the behavior, or if the menu won't work, then it's less expensive to discover that here and now. |
@matthew-carroll can you tell me which Flutter version you used for this branch? logs
Tried again after cleaning pub_cache, with no luck |
@BazinC I brought in the latest changes from As for the Flutter branch - I just tried on Beta and the context menu works, so you don't need to be on For the demo - run the "Example - All Demos" and then choose the iOS super text field from the navigation drawer. When you open the editing toolbar in that demo, it will be the native iOS edit menu. |
Thanks! I'm trying with beta now and it works! (Toolbar position and its arrow position look off but it's not related to this ticket) |
Add popover toolbar builder that uses Flutter's new support for an iOS 16+ system toolbar (Resolves #2032)
Also renamed some files for that were still using the unnecessary underscore "_" prefix.
The following code snippet should let you try the new SuperIOSTextField toolbar: