[SuperEditor] Fix scrolling issue when the editor is inside a horizontal Scrollable (Resolves #501) #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelosilvestre
force-pushed
the
issue-501
branch
from
070c068
to
48ac45f
Compare
super_editor/test/super_editor/supereditor_ancestor_scrollable_test.dart
Outdated
Show resolved
Hide resolved
super_editor/test/super_editor/supereditor_ancestor_scrollable_test.dart
Outdated
Show resolved
Hide resolved
super_editor/test/super_editor/supereditor_ancestor_scrollable_test.dart
Outdated
Show resolved
Hide resolved
…tal Scrollable (Resolves superlistapp#501)
angelosilvestre
force-pushed
the
issue-501
branch
from
6af7774
to
a112a17
Compare
|
@matthew-carroll I changed |
| @@ -41,6 +42,10 @@ class DocumentScrollable extends StatefulWidget { | |||
| /// debugging, when `true`. | |||
| final bool showDebugPaint; | |||
|
|
|||
| /// The [ScrollController] that governs this [DocumentScrollable]'s scroll | |||
| /// offset. | |||
There was a problem hiding this comment.
This controller isn't used when there's an ancestor Scrollable, right? If so, you should probably mention that here, and also mention it in SuperEditor's docs for its ScrollController.
There was a problem hiding this comment.
I added the comment in DocumentScrollable. It was already present in SuperEditor
matthew-carroll
approved these changes
Jul 26, 2022
| (superEditor) => MaterialApp( | ||
| home: ConstrainedBox( | ||
| constraints: const BoxConstraints( | ||
| minWidth: 300, |
There was a problem hiding this comment.
Can you add a comment about why we need such a tiny editor for the test?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[SuperEditor] Fix scrolling issue when the editor is inside a horizontal
Scrollable. Resolves #501When adding the editor to a
TabBarView, once the screen is filled with text, theTabBarViewautomatically changes to the next tab rather than scroll down in the editor.A similar issue happens when adding the editor inside a horizontal
ListView, where adding text causes theListViewto scroll.The problem is that when
SuperEditorhas an ancestorScrollable, it doesn't create its ownSingleChildScrollViewand scrolls the ancestorScrollableinstead. Because of that, widgets that use a horizontalScrollableare affected.I changed it to ignore the ancestor
Scrollableif it has a horizontalAxisDirection.I also added an option in
TestDocumentConfiguratorto configure the subtree betweenMaterialAppandSuperEditor.