Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests for text entry on mobile using an IME simulator in flutter_test_robots (Resolves #620) #729

Merged
merged 1 commit into from
Aug 12, 2022

Conversation

matthew-carroll
Copy link
Contributor

Added tests for text entry on mobile using an IME simulator in flutter_test_robots (Resolves #620)

@matthew-carroll matthew-carroll force-pushed the 620_supertextfield-mobile-text-entry-tests branch from 9798e10 to 3c12eea Compare August 12, 2022 07:08
@matthew-carroll matthew-carroll merged commit 2e81bdc into main Aug 12, 2022
@matthew-carroll matthew-carroll deleted the 620_supertextfield-mobile-text-entry-tests branch August 12, 2022 07:16
Copy link
Collaborator

@angelosilvestre angelosilvestre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

});
});

// TODO: implement newline tests when SuperTextField supports configuration of the action button
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one note: when the text field is multiline it already uses TextInputAction.newline as its input action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add SuperTextField mobile text entry tests
2 participants