Fix hint component and example app toolbar focus (Resolves #726) #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix hint component and example app toolbar focus (Resolves #726)
The hint component's hint text was absorbing gesture interactions, preventing the placement of the caret. Now it ignores the pointer. The tests for this behavior required a modification to our test tools so that we can place the caret in a component that wraps a text component, instead of just a text component.
I also changed the cursor within the editor to always look like a text cursor, unless the cursor is over a selectable box, at which point it looks like a regular cursor again.
Lastly, I did my best to fix the popover toolbar focus issue. By adding a
FocusScopeabove our customOverlayin the example app, the user can tap toolbar buttons like "bold" and "italics" without issue. However, the dropdowns are still broken because they steal focus, and there doesn't seem to be a way to share that focus with the editor.