Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let apps open and close the keyboard on demand, and let selection exist when keyboard is closed (Resolves #875) #876

Merged
merged 27 commits into from
Jan 10, 2023
Merged

Let apps open and close the keyboard on demand, and let selection exist when keyboard is closed (Resolves #875) #876

merged 27 commits into from
Jan 10, 2023

Commits on Dec 3, 2022

  1. Added a demo with a panel behind a keyboard

    @matthew-carroll
    matthew-carroll committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    3aa15cb View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2022

  1. WIP: Demo can close and open keyboard, selection remains when keyboar… 

    …d is down, but selection is explicitly removed when toolbar is closed.
    @matthew-carroll
    matthew-carroll committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    0efd398 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2022

  1. WIP: Debugging user typing in SuperEditor

    @matthew-carroll
    matthew-carroll committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    a1ba670 View commit details
    Browse the repository at this point in the history

  2. Fixed a broken test

    @matthew-carroll
    matthew-carroll committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    d8485e6 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2022

  1. Fixed a composing region bug

    @matthew-carroll
    matthew-carroll committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    91d9109 View commit details
    Browse the repository at this point in the history

  2. Adjusted an assertion

    @matthew-carroll
    matthew-carroll committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    034ae44 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2022

  1. Keyboard panel demo - apply MediaQuery viewInsets to SuperEditor so S… 

    …uperEditor doesn't flow behind keyboard panel.
    @matthew-carroll
    matthew-carroll committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    d1e7267 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2022

  1. Tapping on a document that's being edited by a non-keyboard panel won… 

    …'t re-open keyboard
    @matthew-carroll
    matthew-carroll committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    429d2b1 View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2022

  1. Don't clear selection on double tap or triple tap when they can find … 

    …a new selection
    @matthew-carroll
    matthew-carroll committed Dec 17, 2022
    Configuration menu
    Copy the full SHA
    921d1db View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2022

  1. Added tests, and moved IME keyboard policy to DocumentComposer

    @matthew-carroll
    matthew-carroll committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    e4a8af4 View commit details
    Browse the repository at this point in the history

Commits on Jan 1, 2023

  1. WIP: IME refactor checkin. All tests passing.

    @matthew-carroll
    matthew-carroll committed Jan 1, 2023
    Configuration menu
    Copy the full SHA
    18212ce View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2023

  1. Checkin before trying to simplify IME API

    @matthew-carroll
    matthew-carroll committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    4f636be View commit details
    Browse the repository at this point in the history

  2. Changed ImeFocusPolicy to take a TextInputConnection so that it's usa… 

    …ble outside of SuperEditor
    @matthew-carroll
    matthew-carroll committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    2f54f49 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2023

  1. Changed DocumentSelectionOpenAndCloseImePolicy to use a regular Flutt… 

    …er IME artifacts so that it can be used outside of SuperEditor
    @matthew-carroll
    matthew-carroll committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    0ce2353 View commit details
    Browse the repository at this point in the history

  2. Converted existing Super Editor keyboard interactor into a genericall… 

    …y named widget and used it in the IME interactor
    @matthew-carroll
    matthew-carroll committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    bc10e34 View commit details
    Browse the repository at this point in the history

  3. WIP: committing after fixing some nasty frame timing bugs in the midd… 

    …le of further API simplification
    @matthew-carroll
    matthew-carroll committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    5a0c29d View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2023

  1. WIP: Simplified interactor tree, also changed synchronizer API to tak… 

    …e vanilla Flutter IME artifacts.
    @matthew-carroll
    matthew-carroll committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    07a83b0 View commit details
    Browse the repository at this point in the history

  2. WIP: Removed DocumentImeConnection and related APIs

    @matthew-carroll
    matthew-carroll committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    e0e1ceb View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2023

  1. WIP: Created a SoftwareKeyboard widget to open and close keyboard ins… 

    …tead of implementing directly on SuperEditorImeInteractor
    @matthew-carroll
    matthew-carroll committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    fe1dc09 View commit details
    Browse the repository at this point in the history

  2. WIP: Moved IME opening and closing policy configurations into a new d… 

    …ata structure called SuperEditorImePolicies
    @matthew-carroll
    matthew-carroll committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    1b14c5d View commit details
    Browse the repository at this point in the history

  3. WIP: Minor refactoring checkin

    @matthew-carroll
    matthew-carroll committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    101f503 View commit details
    Browse the repository at this point in the history

  4. WIP: Converted DocumentComposer's concept of composing region from Te… 

    …xtRange to DocumentRange
    @matthew-carroll
    matthew-carroll committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    fe2c5f3 View commit details
    Browse the repository at this point in the history

  5. Finalized API rework by reworking some complexity in document_ime_com… 

    …munication.dart
    @matthew-carroll
    matthew-carroll committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    4e3dd9d View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into 875_panel-behind-keyboard

    @matthew-carroll
    matthew-carroll committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    370a922 View commit details
    Browse the repository at this point in the history

  7. Renamed SoftwareKeyboard to SoftwareKeyboardOpener

    @matthew-carroll
    matthew-carroll committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    0966c65 View commit details
    Browse the repository at this point in the history

  8. Hide ListenableBuilder in mobile_toolbar.dart

    @matthew-carroll
    matthew-carroll committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    121c27f View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2023

  1. Fixed keyboard controller timing issues

    @matthew-carroll
    matthew-carroll committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    03bf977 View commit details
    Browse the repository at this point in the history