Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed SuperTextField selection glitch by never resending the previous TextEditingValue to the IME (Resolves #905) #910

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

matthew-carroll
Copy link
Contributor

Fixed SuperTextField selection glitch by never resending the previous TextEditingValue to the IME (Resolves #905)

@matthew-carroll
Copy link
Contributor Author

This PR needs #876 to land first because we use a decorate introduced in that PR.

Copy link
Collaborator

@miguelcmedeiros miguelcmedeiros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 👍

Copy link
Collaborator

@angelosilvestre angelosilvestre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matthew-carroll matthew-carroll force-pushed the 905_fix-supertextfield-selection-glitch branch from a3c3f6d to 34a53aa Compare January 10, 2023 04:18
@matthew-carroll matthew-carroll merged commit 039f606 into main Jan 10, 2023
@matthew-carroll matthew-carroll deleted the 905_fix-supertextfield-selection-glitch branch January 10, 2023 04:26
matthew-carroll added a commit that referenced this pull request Jan 10, 2023
matthew-carroll added a commit that referenced this pull request Jan 10, 2023
raulmabe-labhouse pushed a commit to LabhouseMobile/super_editor that referenced this pull request Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Selection glitch in SuperTextField when IME is used
3 participants