Skip to content

Commit

Permalink
Adds static instance getter to DefaultMobileMenuWidgetBuilder (#335)
Browse files Browse the repository at this point in the history
Calling `DeviceInfoPlugin().deviceInfo` for every instance of
`ContextMenuWidget` is expensive if there are multiple ones created
during single frame. This adds a static instance accessor to
`DefaultMobileMenuWidgetBuilder` to reuse result of a single call to
`DeviceInfoPlugin().deviceInfo`.
  • Loading branch information
kpsroka committed Mar 25, 2024
1 parent 6737ff2 commit a4b1472
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,9 @@ class DefaultMobileMenuWidgetBuilder extends MobileMenuWidgetBuilder {
}
}

static final DefaultMobileMenuWidgetBuilder instance =
DefaultMobileMenuWidgetBuilder();

/// Allows overriding brightness for the menu UI.
final Brightness? _brightness;

Expand Down
2 changes: 1 addition & 1 deletion super_context_menu/lib/src/menu.dart
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ class ContextMenuWidget extends StatelessWidget {
}) : assert(previewBuilder == null || deferredPreviewBuilder == null,
'Cannot use both previewBuilder and deferredPreviewBuilder'),
mobileMenuWidgetBuilder =
mobileMenuWidgetBuilder ?? DefaultMobileMenuWidgetBuilder(),
mobileMenuWidgetBuilder ?? DefaultMobileMenuWidgetBuilder.instance,
desktopMenuWidgetBuilder =
desktopMenuWidgetBuilder ?? DefaultDesktopMenuWidgetBuilder();

Expand Down

0 comments on commit a4b1472

Please sign in to comment.