feat: Harden NodeGroupRole by denying VPC actions. #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Miradorn
force-pushed
the
feat/35-node-hardening
branch
from
3d7aacb
to
f4ac1b4
Compare
bracki
requested changes
Feb 5, 2021
Theese actions are not necessary, since they are performed by the managed VPC CNI Addon, which uses its own role via IRSA. Therefore the Node Roles shouldn't be allowed to perform them.
Miradorn
force-pushed
the
feat/35-node-hardening
branch
from
f4ac1b4
to
af127ab
Compare
bracki
approved these changes
Feb 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Theese actions are not necessary, since they are performed by the
managed VPC CNI Addon, which uses its own role via IRSA.
Therefore the Node Roles shouldn't be allowed to perform them.
Fixes #35