Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to specify a custom location for report generation #43

Merged
merged 7 commits into from
Jan 3, 2014

Conversation

kattrali
Copy link
Contributor

Changes

  • renamed constructor in bin/xcpretty to printer_opts
  • added report_options to bin/xcpretty to handle custom report path argument
  • use path option in JUnit reporter if specified, otherwise defaults to original location at build/reports/junit.xml
  • move bin/xcpretty helper methods into XCPretty::Runner class

Note

This is a breaking change to reporter functionality. If anyone has a custom reporter, the constructor now takes an options hash.

Fixes #42

@supermarin
Copy link
Contributor

As far as I can tell, right now this is supporting many reporters but one file path.
amirite?

If yes, we should definitely support path per output.
Either -r junit -o junit.xml -r html -o tests.html or -r junit=junit.xml -r html=tests.html would work

@kattrali
Copy link
Contributor Author

kattrali commented Jan 1, 2014

I think we're set here now. The major change is that the arguments are slightly stateful-- --output can't be specified before --report, since the report options are assigned in order.

kattrali added a commit that referenced this pull request Jan 3, 2014
Add option to specify a custom location for report generation
@kattrali kattrali merged commit 213a5a4 into master Jan 3, 2014
@kattrali kattrali deleted the custom-reporter-file branch April 4, 2014 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

option to rename junit reporter output file
2 participants