-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(#52): Set the colorscheme when lazyloading the plugin #53
base: main
Are you sure you want to change the base?
fix(#52): Set the colorscheme when lazyloading the plugin #53
Conversation
@arnevm123, in my personal opinion the changes of setting the highlight without listening to an event should be done in |
Then we'd have to make a setupColors function in util or a separate file, as the code in your PR is a bit too convoluted to be maintained in 2 places. |
I thought the same thing, that's why I said it as an opinion. I mean the code still gets the job done as it is and it's not like it needs to be in the |
There are some users, (e.g. as mentioned in #49 ) who seem to have their own logic involving e: although I suppose that would have been the intended/original effect, and it is only working right now due to this bug |
@sm-victorw I tested it and it seems if I have this config: require("supermaven-nvim").setup({
color = {
suggestion_color = vim.api.nvim_get_hl(0, { name = "NonText" }).fg,
cterm = vim.api.nvim_get_hl(0, { name = "NonText" }).cterm,
},
})
require("supermaven-nvim.completion_preview").suggestion_group = "SupermavenSuggestion" If If doing what I suggested in #53 (comment) it won't break. |
@sm-victorw @arnevm123 here is a demo of the changes, first to appear is when setting it initially in document_listener-vs-init_lua.mp4 |
One more thing, if doing the same with the PR #51 it will default to |
When the plugin gets loaded we call the function first, so VimEnter is not needed anymore.
If you would like to fix this another way, please let me know.
fixes #52