Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to matrix4 #78

Merged
merged 2 commits into from
Dec 15, 2022
Merged

Conversation

kylebakerio
Copy link
Contributor

@kylebakerio kylebakerio commented Oct 3, 2022

  • I noticed that these applyMatrix() calls throw a warning in 1.3.0, and break current master.
  • I was not able to get any tests to run, and had to try several versions of node to get an npm install working; almost filed an issue for not being able to npm install, but upgrading to node 16.17.1 did it, finally. Trying to run tests, karma complains a config file is running. Trying to run manually without config file, I get nothing. I did see a guide to contributing, so I assume tests aren't a thing right now; if I need to do something else, let me know.
  • I noticed that on the readme, the github.io site is pointing to a page that is on A-Frame 0.7.0. Index.html is not nearly so out of date, though--it points to 1.2.0. You might have github pointed at a gh-pages branch, or have some other configuration error. I went ahead and updated it to 1.3.0, anyways, for now.

@dmarcos
Copy link
Member

dmarcos commented Dec 15, 2022

Thank you!

@vincentfretin
Copy link
Contributor

The release 1.3.2 contains the changes, you can now use the following url:

<script src="https://unpkg.com/aframe-environment-component@1.3.2/dist/aframe-environment-component.min.js"></script>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants