[buffer-geometry-merger] Fix to work with dynamic elements #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The buffer-geometry-merger, as it was, does not work when you inject (using JavaScript) some components in a DOM subtree, and then apply it to merge all geometries in the subtree. See details in https://stackoverflow.com/questions/59110629/a-frame-buffer-geometry-merger-seems-to-shift-entities-in-some-cases/59513236#59513236 This fix bakes the matrixes of the components into the cloned geometries, so that when they are merged into a single one, it is correctly positioned. I also change the updating of the world matrixes for all the scene, to the updating of the world matrixes for the intended subtree. In the process, I also added a definition for self, which was used in the code, but not defined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
buffer-geometry-merger, as it was, does not work when you inject (using JavaScript) some components in a DOM subtree, and then apply it to merge all geometries in the subtree. See details inhttps://stackoverflow.com/questions/59110629/a-frame-buffer-geometry-merger-seems-to-shift-entities-in-some-cases/59513236#59513236
This fix bakes the matrixes of the components into the cloned geometries, so that when they are merged into a single one, it is correctly positioned. I also change the updating of the world matrixes for all the scene, to the updating of the world matrixes for the intended subtree.
In the process, I also added a definition for
self, which was used in the code, but not defined.