Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function external_perimeter_cut_corners #1903

Closed
macchinette opened this issue Nov 16, 2021 · 3 comments
Closed

Function external_perimeter_cut_corners #1903

macchinette opened this issue Nov 16, 2021 · 3 comments
Labels
fix is live in the last release Please download /build the last release and try to reproduce. question

Comments

@macchinette
Copy link

Describe the bug
Maybe it's not a bug, but a function definition.

To Reproduce
Steps to reproduce the behavior:

  1. Open 3mf attachment
  2. Cut files
  3. View the volumetric flow rate
  4. See volumetric flow rate in the corners of the cube

>> Project File <<

external_perimeter_cut_corners.zip

Expected behavior
I would like to understand how it has to work, because I thought it would reduce the flow before the corner to make the corners sharper and instead the flow remains unchanged.
I have seen that after the angle the flow is the same, but soon after it is increased for a small moment and then it returns to normal.

Screenshots
image

Desktop (please complete the following information):

  • OS: Windows 10 Pro
  • Version SuperSlicer_2.3.57.5

Additional context
It could be a great feature.

@supermerill
Copy link
Owner

first extrusion going into a corner
image

what we want but can't have
image

what happens (theoretically)
image

what cut_corners at 100% should do
image

@macchinette
Copy link
Author

Okay so the function is very good!
It just doesn't apply right, because if I understand when it starts again from the corner it has to reduce the flow and if it does, it immediately increases the flow again and that's not good.
When you have time, can you check if it applies properly?
Thanks

@supermerill
Copy link
Owner

supermerill commented Nov 17, 2021

just checked, and there `was a problem.
current:

 write1 dist 0.141001, mult1=0.892699, length1 = 0.141
 write1 0.0386785
 write2 dist 0.141, mult2=0.94635, length2 = 0.282
 write2 0.0820068
 write3 dist 3.954, mult=1, length2 = 3.813
 write3 0.0417829

fixed:

 write1 dist 0.141001, mult1=0.892699, length1 = 0.141
 write1 0.0386785
 write2 dist 0.282, mult2=0.94635, length2 = 0.282
 write2 0.0410034
 write3 dist 3.813, mult=1, length2 = 3.813
 write3 0.043328

better now:
image

@supermerill supermerill added the fixed for the next version That means that you should be able to test it in the latest nightly build label Nov 17, 2021
supermerill added a commit that referenced this issue Nov 18, 2021
was extruding less at the wrong segment.
#1903
@supermerill supermerill added fix is live in the last release Please download /build the last release and try to reproduce. and removed fixed for the next version That means that you should be able to test it in the latest nightly build labels Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix is live in the last release Please download /build the last release and try to reproduce. question
Projects
None yet
Development

No branches or pull requests

2 participants