Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add confirmation box for color change #4075

Closed
supermerill opened this issue Jan 16, 2024 · 5 comments
Closed

Add confirmation box for color change #4075

supermerill opened this issue Jan 16, 2024 · 5 comments
Labels
easy enhancement fix is live in the last release Please download /build the last release and try to reproduce.

Comments

@supermerill
Copy link
Owner

It's easy to click at the wrong place and add a color change and so invalidating the current sliced code.
It's best to add a preference item so a confirmation dialog prevent the color change if it was unintentional.

@supermerill supermerill changed the title Add confiramtion box for color change Add confirmation box for color change Jan 16, 2024
@legend069
Copy link

is this for the "popup" that appears when it thinks the model looks like something and asks if you want to apply the color change gcode?
or is it for the miss click on the layer height slider?

@supermerill
Copy link
Owner Author

For miss click
Often, I just want to look to another layer and I add a color change and then the gcode is invalidated and i have to wait for it to recompute before removing it.
One day, i'll do something to keep the invalided data, and color the slice button red instead, or something.

@legend069
Copy link

i thought about approaching this by just moving the box for it a few pixels over, or making it larger/smaller.
but the don't show again bit for it would prob be best.

if adding a "are you sure" checkbox, it should come with a enable/disable, do not show again
just to save the possibility it could annoy users that utilize the multi-material features frequently.

@supermerill
Copy link
Owner Author

yes

@supermerill supermerill added the fixed for the next version That means that you should be able to test it in the latest nightly build label Jan 31, 2024
@supermerill
Copy link
Owner Author

You're right, there is enough space.
I pushed the button to the far side
Also added a little empty unresponsive space between the lock button and the bottom of the slider, as I also do many miss clicks here.
I'll see how it goes in the long run

supermerill added a commit that referenced this issue Jan 31, 2024
 . Push the (+) color change button as far away as possible
 . Add a little dead zone between the bottom and the lock icon.
 . Also fix a crash that can happen when a color change is done and the computer is a bit slow.
#4075
supermerill added a commit that referenced this issue Feb 1, 2024
 . Push the (+) color change button as far away as possible
 . Add a little dead zone between the bottom and the lock icon.
 . Also fix a crash that can happen when a color change is done and the computer is a bit slow.
#4075
supermerill added a commit that referenced this issue Feb 2, 2024
 . Push the (+) color change button as far away as possible
 . Add a little dead zone between the bottom and the lock icon.
 . Also fix a crash that can happen when a color change is done and the computer is a bit slow.
#4075
@supermerill supermerill added fix is live in the last release Please download /build the last release and try to reproduce. and removed fixed for the next version That means that you should be able to test it in the latest nightly build labels Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy enhancement fix is live in the last release Please download /build the last release and try to reproduce.
Projects
None yet
Development

No branches or pull requests

2 participants