Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Custom Thumbnail Color #447

Closed
dw-0 opened this issue Sep 4, 2020 · 8 comments
Closed

[Feature Request] Custom Thumbnail Color #447

dw-0 opened this issue Sep 4, 2020 · 8 comments
Labels
fix is live in the last release Please download /build the last release and try to reproduce. new Feature New feature or request

Comments

@dw-0
Copy link

dw-0 commented Sep 4, 2020

This might be a rather a rather playful feature request. At the moment, thumbnails will always be generated in that specific orange-ish prusa color.

Would it be possible to make the color of the model displayed on the thumbnail customizable? Through an user defined hexcode in the Gcode thumbnails printer settings?

Iirc, you are a Klipper guy and using Mainsail yourself (?), where thumbnails will be shown in the gcode list and (which is a new feature) as a preview in the status screen when printing that model. With such a feature, it would be possible to either match the Mainsail color scheme or at least make that color user defined and much more appealing.

What do you think of it? Too much gimmick?

@supermerill supermerill added the new Feature New feature or request label Sep 4, 2020
@n8bot
Copy link

n8bot commented Sep 4, 2020

What about matching the actual colour of the print? Some colours might have low-contrast with the bg, though.

@dw-0
Copy link
Author

dw-0 commented Sep 5, 2020

@n8bot Might be also a cool idea. Either having the option to specify the thumbail color through HSL/RGB values or like have a checkbox to enable to color from the filament profile.

@neophyl
Copy link

neophyl commented Sep 5, 2020

Theres a feature request on the Prusa github for the thumbnail to match the filament colour I remember seeing. I reckon you have far more chance getting it on Super Slicer though :)

@lixxbox
Copy link

lixxbox commented Sep 6, 2020

Maybe you could use the extruder color from printer settings. If ‚undefined‘ I think the filament color is taken instead.

The render color (orange) is defined there:

static const GLfloat orange[] = { 0.923f, 0.504f, 0.264f, 1.0f };

It might also be a good idea to add an option to not render the bed, there seems to be a boolean option for that.

@supermerill
Copy link
Owner

I change the color to the current object color (from the filament color set on the top-right widget)
I added a checkbox to make the bed disappear.

It is really useful to enforce a specific color? I'll do a release without, and if there is a real need, i'll add it.

@supermerill supermerill added the fixed for the next version That means that you should be able to test it in the latest nightly build label Sep 6, 2020
@dw-0
Copy link
Author

dw-0 commented Sep 6, 2020

Enforcing a color: no, why? thats exactly what we (at least me) don't want...therefore that feature request :P

Make color current object color: good

what about this approach?
Make color selectable by user in the settings (which can be different to the object color and would overwrite it!): would be cool!

@supermerill
Copy link
Owner

supermerill commented Sep 6, 2020

Make color selectable by user in the setting

that means that you enforce a specific color ?

example with color from filament & no bed:
image

@dw-0
Copy link
Author

dw-0 commented Sep 6, 2020

Ah, now i understand you correctly. Yes...but it just enforces a user defined color then.

Example: You use Mainsail and you want your thumbnails to be green. But you upload a g-code which uses the filament color of gray. You will barely see the image, since Mainsails color-scheme is also mostly gray. And maybe you don't want to change the filament color in your filament profile from gray to green only for the thumbnail because you use the filament color in the profile for managing reasons.

supermerill added a commit that referenced this issue Sep 6, 2020
supermerill added a commit that referenced this issue Sep 6, 2020
@supermerill supermerill added fix is live in the last release Please download /build the last release and try to reproduce. and removed fixed for the next version That means that you should be able to test it in the latest nightly build labels Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix is live in the last release Please download /build the last release and try to reproduce. new Feature New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants