Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The meaning of "project" is inconsistent #949

Open
JohanAR opened this issue Feb 6, 2021 · 7 comments
Open

The meaning of "project" is inconsistent #949

JohanAR opened this issue Feb 6, 2021 · 7 comments

Comments

@JohanAR
Copy link

JohanAR commented Feb 6, 2021

Version

2.3.55.4

Operating system type + version

Xubuntu 20.04.2 LTS

3D printer brand / version + firmware version (if known)

N/A

Behavior

  • "New Project" resets the plater, but does not touch the settings. Any modified settings are kept.
  • "Open Project..." replaces both plater and settings. Any modified settings are silently discarded.
  • Undo after opening a new project reverts the plater contents, but does not revert the loaded settings.

The problem is that a "project" sometimes means only models on the plater, and sometimes both plater contents and settings.

Proposed solution

  • Have "project" always refer to a combination of plater (which may or may not contain models) and settings.
  • If it should be possible to undo an "open project", it needs to revert both plater contents and settings together. Personally I don't think undoing switching projects is necessary, it is not a feature I expect. It would of course be nice to have, but I think it might add a lot of complexity to the code.
  • If it should not be possible to undo an "open project", it should present the user with the unsaved changes dialog, giving them the option to save/transfer/discard changes.

Project File (.3MF) where problem occurs

N/A

@Redferne
Copy link

Redferne commented Feb 9, 2021

Yes, I have this problem as well. I'm afraid of loading old projects since the current settings are lost forever.

@azaz44
Copy link

azaz44 commented Mar 6, 2021

I have this problem too, and had a situation where it is really dangerous. I printed PLA at 250 degrees because of that.

Steps to reproduce:

  1. Use menu Calibration ->Filament Temperature Calibration to generate a temp tower
  2. Slice it
  3. Now, you don't need it anymore, and want to print something new
  4. Delete the tower from the plate
  5. Now try to make "New Project" -- you can't. It is greyed out.
  6. Add any STL to the plate and slice.
  7. Now you think you are fine printing it. But actually your code contains G-Codes for temperature switching left from the previous project.

If, however, you would use "New Project" when the tower was still at the plate (and the option was available), temp G-codes would be gone.

@supermerill
Copy link
Owner

And currently, when there is only one object, "delete" (one) is not the same as "delete all" because the second one is in fact "new project" ....

Also, ctrl+z may restore the previous parts but not the previous settings...

Have to do something here.

Ideally, a "recent projects" list in the menu may be useful.

@azaz44
Copy link

azaz44 commented Mar 18, 2021

Well, the easiest fix to get something done quickly is to

  • have "New Project" available always (unless software can detect that "New Project" is not needed, but this is probably more complex and risky to have bugs in it)
  • make sure it clears all the settings, which I think it seems to do

What user needs is some confidence, that he does not inherit anything from the previous settings when he starts a new print. So I think "New Project" should have same result as restarting Super Slicer.

About "delete all" -- I think user expectation would be just to remove parts, not change settings. But yes, it gets tricky here... because why would you delete all parts if you're not starting a new project...

@supermerill
Copy link
Owner

About "delete all" -- I think user expectation would be just to remove parts, not change settings. But yes, it gets tricky here... because why would you delete all parts if you're not starting a new project...

I think I will change the pop-up from "yes" "no"(cancel) "cancel" to "Remove objects" "New project" "Cancel"

supermerill pushed a commit that referenced this issue Mar 21, 2021
 - ask for saving the project if unsaved changes
 - ask for preset reset if new project
 - delete all : new project or just delete?
@grantemsley
Copy link

Along these lines, when opening a .3mf file that includes settings, it would be really nice if I got a prompt like:

Use settings from this project?
---------------------------         ----------------------------------
|Yes, use project settings|         |No, keep current slicer settings|
---------------------------         ----------------------------------

Clicking yes would import all the settings from the project, overwriting your current slicer settings.

No would keep your existing print, filament and printer settings - but ideally still import any per-object settings that were saved in the file.

@supermerill
Copy link
Owner

understood

I have to create some flow chart documentation, so I can keep track on what should be doing what.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants