Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsonpath function always duplicates input string for unescaping #164

Closed
mk6i opened this issue Apr 9, 2022 · 0 comments
Closed

jsonpath function always duplicates input string for unescaping #164

mk6i opened this issue Apr 9, 2022 · 0 comments

Comments

@mk6i
Copy link
Collaborator

mk6i commented Apr 9, 2022

The main jsonpath() function always duplicates the input string passed to the lexer so that the lexer can modify the expression without modifying the input string. The lexer currently unescapes the input string by shifting characters. This was done in order to support escaped string literals in jsonpath. Duplicating the string requires a malloc() and corresponding free(). In order to improve overall performance of the extension, let's try to avoid this string duplication.

crocodele added a commit that referenced this issue Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants