Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap all functionality in the JsonPath namespace #122

Merged
merged 3 commits into from
Jul 9, 2021
Merged

Wrap all functionality in the JsonPath namespace #122

merged 3 commits into from
Jul 9, 2021

Conversation

crocodele
Copy link
Collaborator

Fixes #121.

@crocodele crocodele requested a review from mk6i July 9, 2021 17:55
@github-actions github-actions bot added the feature New feature label Jul 9, 2021
@github-actions github-actions bot added the chore Grunt task label Jul 9, 2021
@crocodele crocodele removed the request for review from mk6i July 9, 2021 18:05
@crocodele crocodele requested a review from mk6i July 9, 2021 18:42
mk6i
mk6i approved these changes Jul 9, 2021
View reviewed changes
Copy link
Collaborator

@mk6i mk6i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mk6i mk6i merged commit 3694f79 into main Jul 9, 2021
@mk6i mk6i deleted the feature/IntroduceNamespace branch July 9, 2021 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mk6i mk6i mk6i approved these changes

Assignees
No one assigned
Labels
chore Grunt task feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The extension code should be wrapped in a namespace
2 participants
@crocodele @mk6i