Disable PCRE jit to avoid alleged valgrind errors. #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So........there is a reasonable chance the alleged read from uninitialized memory is a false report: https://bugs.php.net/bug.php?id=81240 . In particular, as compiling with valgrind support makes the report dissapear it's more likely to be a false report than not.
Disabling the pcre.jit option also makes the issue go away. As you should be occcasionally testing to check for leaks, having the false reports not be there would be better than having people be confused by them.
There's a small chance the error alleged by valgrind is legitimate, and that it should be isolated and reported upstream. But I only have energy for this PR.