Remove FIXME and add proper explanation for draining stdout

superpowers · Oct 1, 2016 · 5e61232 · 5e61232
1 parent 15a7417
commit 5e61232
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/renderer/updateManager.ts b/src/renderer/updateManager.ts
@@ -194,8 +194,8 @@ function updateCore(callback: (error: Error) => void) {
 
       const process = forkServerProcess([ "update", "core", "--force", `--download-url=${registry.core.downloadURL}` ]);
 
-      // FIXME: The update on the core fails somehow if we remove this line
-      process.stdout.on("data", (data: any) => { /* NOTHING */ });
+      // We need to drain stdout otherwise the process gets stuck
+      process.stdout.on("data", (data: any) => { /* Ignore */ });
 
       process.on("message", (event: any) => {
         if (event.type === "error") {