Skip to content
This repository has been archived by the owner on Mar 5, 2021. It is now read-only.

Fix visual bug with smooth font #22

Closed
wants to merge 2 commits into from

Conversation

ShadowTzu
Copy link
Contributor

Smooth font need to have a transparent material because the border has a pixel alpha channel under 1.0

Smooth font need to have a transparent material because the border has a pixel alpha channel under 1.0
@elisee
Copy link
Contributor

elisee commented Jan 20, 2016

Thanks for the PR! It looks like the patch can be simplified to:

    mesh.material.transparent = this.font.filtering === "smooth";

But I'm wondering if this is the correct fix. Shouldn't we just add an Opacity field like in the sprite and model editors / renderer components editors? cc @bilou84

@elisee
Copy link
Contributor

elisee commented Jan 20, 2016

Looks like this is indeed what we had planned: https://trello.com/c/RpdoFljI/683-font-add-opacity-to-component-editor, so let's just do that soon instead.

@ShadowTzu
Copy link
Contributor Author

With a smooth filter there is no case with disabled opacity that is useful

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants