-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added set_audio_output() and updated readme #43
added set_audio_output() and updated readme #43
Conversation
Hi there, Thanks so much for this PR! I have a few questions:
Additionally, as for the actual code changes, I was wondering turning those string into an enum? We don't want to the users to pass in the actual payload string. The best option is to introduce a simple class in |
…utput_sources(), added AudioOutputSource, updated readme
Hi, thanks for your quick reply and your input! I’ve added get_audio_output() which can be subscribed to. |
@supersaiyanmode Whoa! There's a bunch of stuff in here that isn't implement in this project. I'll try to implement and test all of this stuff this week and put in a PR. Do you still not have access to a WebOS TV to test stuff yourself? Man, I should have thought about looking at Home Bridge stuff. |
…adme and removed unnecessary method from AudioOutputSource
Totally! It is disappointing that LG refuses to release any sort of documentation. We have to go hunt for other uses in the wild, come back and implement it. I have access to the TV, but the wireless receiver is non-functional for some reason. If I must test for some reason, it's via a 10ft long ethernet cable 😝. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good overall. Thanks so much for this PR! Just a tiny round of super minor requests :)
Co-authored-by: Srivatsan Iyer <supersaiyanmode@users.noreply.github.com>
Thank you for your time and advise :) |
No description provided.