Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more clarity to using client key #46

Closed
wants to merge 2 commits into from
Closed

add more clarity to using client key #46

wants to merge 2 commits into from

Conversation

thevickypedia
Copy link

merge it or drop it, just felt it would be more clearer this way

merge it or drop it, just felt it would be more clearer this way
@supersaiyanmode
Copy link
Owner

I think the only way readers understand "store" is if I write a quick sample code. I will do it soon.

@thevickypedia
Copy link
Author

I think the only way readers understand "store" is if I write a quick sample code. I will do it soon.

I'm on it now, leaving your part untouched will add few lines to explain it better. Your suggestion really makes sense :)

Copy link
Author

@thevickypedia thevickypedia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified as requested

README.md Show resolved Hide resolved
@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.161% when pulling 668c44b on thevickypedia:patch-1 into fb0b826 on supersaiyanmode:master.

@supersaiyanmode
Copy link
Owner

Please take a look at this PR #47. Let me know if this addresses your questions. I modified quite a few areas of README.md

@thevickypedia
Copy link
Author

Please take a look at this PR #47. Let me know if this addresses your questions. I modified quite a few areas of README.md

That's a lot more than what I was expecting :D Thanks for asking my opinion too 👍🏼

@supersaiyanmode
Copy link
Owner

Sure! Feel free to comment/suggest changes there if you think the README could be improved. I'm closing this PR for now, thanks so much for your help :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants