-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add TV controls channel down and up #9
Conversation
Hi @Gustry can you please explain, what you mean by: "I'm not sure how to give a parameter in my request" ? May be with an example? Do you want to do: |
Yes exactly. But what I put in this PR is working. I didn't commit the |
Ohh, please look at
Think of In other words:
upon invocation like: |
Thanks @Gustry for this PR! 👍 |
In the project referenced in the REAME we can see this: https://github.com/klattimer/LGWebOSRemote/blob/master/LGTV/remote.py#L207 They have:
This merge implements channelUp and Down, so I supose that add setChannel, getChannel and getChannelList will be, with your explanition:
And then I will have available:
PD: Add comment #9 (comment) to the README or as a comment in the code. Is very useful to understand how this works and how you can use and extend. Edit: I tried and its almost working!
The problem is that "with_number" it's not working (and is the more natural: set channel 12). It throws and error (at least in my TV). More people have the same problem: And I tested with channel ID (from channel_list) and it works. So you can perform an initial channel_list an index by number and then call set_channel_with_id(channel_number_to_id[12]) |
Hi @dagavi, thanks so much! The new APIs around TV Channels sound good to me. Would you be open to creating a PR with only those commands that work (in other words minus the channel number)? |
add TV controls channel down and up
I tried to add the channel number, but no luck for now. I'm not sure how to give a parameter in my request. I have another look later maybe.