Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolving issue #375. During conversation the match should retain topic #386

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

alexraj
Copy link

@alexraj alexraj commented Nov 2, 2017

During conversation the match should retain topic

Description

When the topic is switched, and the first gambit is a conversation, it always matches the first topic, rather than switched topic. For more detail refer #375

Motivation and Context

When there are multiple topics with same request gambit, we get multiple replies. The reply inside the current topic should be selected, rather than the first one in replies array. The fix is to move the reply in current topic to beginning of the array.

#375

How Has This Been Tested?

The code is tested with existing test cases. All test cases pass.
6 test cases are added, and all of them passed.

For the expected behavior, tested with the scenario given in issue #375

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@coveralls
Copy link

coveralls commented Nov 2, 2017

Coverage Status

Coverage decreased (-0.2%) to 80.388% when pulling 52fea2a on alexraj:retain-topic-during-conversation into 37f2be9 on superscriptjs:master.

@coveralls
Copy link

coveralls commented Nov 2, 2017

Coverage Status

Coverage increased (+0.07%) to 80.622% when pulling 6960aae on alexraj:retain-topic-during-conversation into 37f2be9 on superscriptjs:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants