Skip to content

Commit

Permalink
some more little fixes for all to enjoy (#161)
Browse files Browse the repository at this point in the history
  • Loading branch information
tsmethurst committed Aug 26, 2021
1 parent 2162f21 commit 30f688d
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 16 deletions.
8 changes: 4 additions & 4 deletions internal/db/bundb/account.go
Original file line number Diff line number Diff line change
Expand Up @@ -217,10 +217,6 @@ func (a *accountDB) GetAccountStatuses(ctx context.Context, accountID string, li
q = q.Limit(limit)
}

if excludeReplies {
q = q.WhereGroup(" AND ", whereEmptyOrNull("in_reply_to_id"))
}

if pinnedOnly {
q = q.Where("pinned = ?", true)
}
Expand All @@ -237,6 +233,10 @@ func (a *accountDB) GetAccountStatuses(ctx context.Context, accountID string, li
})
}

if excludeReplies {
q = q.WhereGroup(" AND ", whereEmptyOrNull("in_reply_to_id"))
}

if err := q.Scan(ctx); err != nil {
return nil, err
}
Expand Down
19 changes: 8 additions & 11 deletions internal/db/bundb/instance.go
Original file line number Diff line number Diff line change
Expand Up @@ -37,20 +37,17 @@ type instanceDB struct {
func (i *instanceDB) CountInstanceUsers(ctx context.Context, domain string) (int, db.Error) {
q := i.conn.
NewSelect().
Model(&[]*gtsmodel.Account{})

if domain == i.config.Host {
// if the domain is *this* domain, just count where the domain field is null
q = q.WhereGroup(" AND ", whereEmptyOrNull("domain"))
} else {
q = q.Where("domain = ?", domain)
}

// don't count the instance account or suspended users
q = q.
Model(&[]*gtsmodel.Account{}).
Where("username != ?", domain).
Where("? IS NULL", bun.Ident("suspended_at"))

if domain == i.config.Host {
// if the domain is *this* domain, just count where the domain field is null
q = q.WhereGroup(" AND ", whereEmptyOrNull("domain"))
} else {
q = q.Where("domain = ?", domain)
}

count, err := q.Count(ctx)

return count, processErrorResponse(err)
Expand Down
2 changes: 1 addition & 1 deletion internal/db/bundb/relationship.go
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ func (r *relationshipDB) AcceptFollowRequest(ctx context.Context, originAccountI
if _, err := r.conn.
NewInsert().
Model(follow).
On("CONFLICT CONSTRAINT follows_account_id_target_account_id_key DO UPDATE set uri = ?", follow.URI).
On("CONFLICT ON CONSTRAINT follows_account_id_target_account_id_key DO UPDATE set uri = ?", follow.URI).
Exec(ctx); err != nil {
return nil, processErrorResponse(err)
}
Expand Down

0 comments on commit 30f688d

Please sign in to comment.