Skip to content

Commit

Permalink
[feature/frogend] modify local emoji (#1143)
Browse files Browse the repository at this point in the history
* update danger button red

* emoji category and image modification

* debug bundles in dev

* fix linting error
  • Loading branch information
f0x52 committed Nov 25, 2022
1 parent b6dbe21 commit 665d902
Show file tree
Hide file tree
Showing 11 changed files with 321 additions and 81 deletions.
7 changes: 4 additions & 3 deletions web/source/css/_colors.css
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ $blue3: #89caff; /* hover/selected accent to $blue2, can be used with $gray1 (7.

$error1: #860000; /* Error border/foreground text, can be used with $error2 (5.0), $white1 (10), $white2 (5.1) */
$error2: #ff9796; /* Error background text, can be used with $error1 (5.0), $gray1 (6.6), $gray2 (5.3), $gray3 (4.8) */
$error3: #dd2c2c; /* Error button background text, can be used with $white1 (4.51) */
$error-link: #185F8C; /* Error link text, can be used with $error2 (5.54) */

$fg: $white1;
Expand All @@ -69,9 +70,9 @@ $button-bg: $blue2;
$button-fg: $gray1;
$button-hover-bg: $blue3;

$button-danger-bg: $orange1;
$button-danger-fg: $gray1;
$button-danger-hover-bg: $orange2;
$button-danger-bg: $error3;
$button-danger-fg: $white1;
$button-danger-hover-bg: $error2;

$toot-focus-bg: $gray5;
$toot-unfocus-bg: $gray2;
Expand Down
10 changes: 10 additions & 0 deletions web/source/css/base.css
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,16 @@ main {
}
}

&:disabled {
color: $white2;
background: $gray2;
cursor: auto;

&:hover {
background: $gray3;
}
}

&:hover {
background: $button-hover-bg;
}
Expand Down
1 change: 0 additions & 1 deletion web/source/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@ skulk({
],
},
settings: {
debug: false,
entryFile: "settings",
outputFile: "settings.js",
prodCfg: prodCfg,
Expand Down
96 changes: 96 additions & 0 deletions web/source/settings/admin/emoji/category-select.jsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,96 @@
/*
GoToSocial
Copyright (C) 2021-2022 GoToSocial Authors admin@gotosocial.org
This program is free software: you can redistribute it and/or modify
it under the terms of the GNU Affero General Public License as published by
the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU Affero General Public License for more details.
You should have received a copy of the GNU Affero General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>.
*/

"use strict";

const React = require("react");
const splitFilterN = require("split-filter-n");
const syncpipe = require('syncpipe');
const { matchSorter } = require("match-sorter");

const query = require("../../lib/query");

const ComboBox = require("../../components/combo-box");

function useEmojiByCategory(emoji) {
// split all emoji over an object keyed by the category names (or Unsorted)
return React.useMemo(() => splitFilterN(
emoji,
[],
(entry) => entry.category ?? "Unsorted"
), [emoji]);
}

function CategorySelect({value, categoryState, setIsNew=() => {}, children}) {
const {
data: emoji = [],
isLoading,
isSuccess,
error
} = query.useGetAllEmojiQuery({filter: "domain:local"});

const emojiByCategory = useEmojiByCategory(emoji);

const categories = React.useMemo(() => new Set(Object.keys(emojiByCategory)), [emojiByCategory]);

// data used by the ComboBox element to select an emoji category
const categoryItems = React.useMemo(() => {
return syncpipe(emojiByCategory, [
(_) => Object.keys(_), // just emoji category names
(_) => matchSorter(_, value, {threshold: matchSorter.rankings.NO_MATCH}), // sorted by complex algorithm
(_) => _.map((categoryName) => [ // map to input value, and selectable element with icon
categoryName,
<>
<img src={emojiByCategory[categoryName][0].static_url} aria-hidden="true"></img>
{categoryName}
</>
])
]);
}, [emojiByCategory, value]);

React.useEffect(() => {
if (value != undefined && isSuccess && value.trim().length > 0) {
setIsNew(!categories.has(value.trim()));
}
}, [categories, value, setIsNew, isSuccess]);

if (error) { // fall back to plain text input, but this would almost certainly have caused a bigger error message elsewhere
return (
<>
<input type="text" placeholder="e.g., reactions" onChange={(e) => {categoryState.value = e.target.value;}}/>;
</>
);
} else if (isLoading) {
return <input type="text" value="Loading categories..." disabled={true}/>;
}

return (
<ComboBox
state={categoryState}
items={categoryItems}
label="Category"
placeHolder="e.g., reactions"
children={children}
/>
);
}

module.exports = {
useEmojiByCategory,
CategorySelect
};
148 changes: 115 additions & 33 deletions web/source/settings/admin/emoji/detail.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,65 +22,147 @@ const React = require("react");

const { useRoute, Link, Redirect } = require("wouter");

const BackButton = require("../../components/back-button");
const { CategorySelect } = require("./category-select");
const { useComboBoxInput, useFileInput } = require("../../components/form");

const query = require("../../lib/query");
const FakeToot = require("../../components/fake-toot");

const base = "/settings/admin/custom-emoji";

/* We wrap the component to generate formFields with a setter depending on the domain
if formFields() is used inside the same component that is re-rendered with their state,
inputs get re-created on every change, causing them to lose focus, and bad performance
*/
module.exports = function EmojiDetailWrapped() {
let [_match, {emojiId}] = useRoute(`${base}/:emojiId`);
module.exports = function EmojiDetailRoute() {
let [_match, params] = useRoute(`${base}/:emojiId`);
if (params?.emojiId == undefined) {
return <Redirect to={base}/>;
} else {
return (
<div className="emoji-detail">
<Link to={base}><a>&lt; go back</a></Link>
<EmojiDetailData emojiId={params.emojiId}/>
</div>
);
}
};

function EmojiDetailData({emojiId}) {
const {currentData: emoji, isLoading, error} = query.useGetEmojiQuery(emojiId);

return (<>
{error && <div className="error accent">{error.status}: {error.data.error}</div>}
{isLoading
? "Loading..."
: <EmojiDetail emoji={emoji}/>
}
</>);
};
if (error) {
return (
<div className="error accent">
{error.status}: {error.data.error}
</div>
);
} else if (isLoading) {
return "Loading...";
} else {
return <EmojiDetail emoji={emoji}/>;
}
}

function EmojiDetail({emoji}) {
if (emoji == undefined) {
return (<>
<Link to={base}>
<a className="button">go back</a>
</Link>
</>);
const [modifyEmoji, modifyResult] = query.useEditEmojiMutation();

const [isNewCategory, setIsNewCategory] = React.useState(false);

const [categoryState, _resetCategory, { category }] = useComboBoxInput("category", {defaultValue: emoji.category});

const [onFileChange, _resetFile, { image, imageURL, imageInfo }] = useFileInput("image", {
withPreview: true,
maxSize: 50 * 1024
});

function modifyCategory() {
modifyEmoji({id: emoji.id, category: category.trim()});
}

function modifyImage() {
modifyEmoji({id: emoji.id, image: image});
}

React.useEffect(() => {
if (category != emoji.category && !categoryState.open && !isNewCategory && emoji.category != undefined) {
console.log("updating to", category);
modifyEmoji({id: emoji.id, category: category.trim()});
}
}, [isNewCategory, category, categoryState.open, emoji.category, emoji.id, modifyEmoji]);

return (
<div>
<h1><BackButton to={base}/> Custom Emoji: {emoji.shortcode}</h1>
<DeleteButton id={emoji.id}/>
<p>
Editing custom emoji isn&apos;t implemented yet.<br/>
<a target="_blank" rel="noreferrer" href="https://github.com/superseriousbusiness/gotosocial/issues/797">View implementation progress.</a>
</p>
<img src={emoji.url} alt={emoji.shortcode} title={`:${emoji.shortcode}:`}/>
</div>
<>
<div className="emoji-header">
<img src={emoji.url} alt={emoji.shortcode} title={emoji.shortcode}/>
<div>
<h2>{emoji.shortcode}</h2>
<DeleteButton id={emoji.id}/>
</div>
</div>

<div className="left-border">
<h2>Modify this emoji {modifyResult.isLoading && "(processing..)"}</h2>

{modifyResult.error && <div className="error">
{modifyResult.error.status}: {modifyResult.error.data.error}
</div>}

<div className="update-category">
<CategorySelect
value={category}
categoryState={categoryState}
setIsNew={setIsNewCategory}
>
<button style={{visibility: (isNewCategory ? "initial" : "hidden")}} onClick={modifyCategory}>
Create
</button>
</CategorySelect>
</div>

<div className="update-image">
<b>Image</b>
<div className="form-field file">
<label className="file-input button" htmlFor="image">
Browse
</label>
{imageInfo}
<input
className="hidden"
type="file"
id="image"
name="Image"
accept="image/png,image/gif"
onChange={onFileChange}
/>
</div>

<button onClick={modifyImage} disabled={image == undefined}>Replace image</button>

<FakeToot>
Look at this new custom emoji <img
className="emoji"
src={imageURL ?? emoji.url}
title={`:${emoji.shortcode}:`}
alt={emoji.shortcode}
/> isn&apos;t it cool?
</FakeToot>
</div>
</div>
</>
);
}

function DeleteButton({id}) {
// TODO: confirmation dialog?
const [deleteEmoji, deleteResult] = query.useDeleteEmojiMutation();

let text = "Delete this emoji";
let text = "Delete";
if (deleteResult.isLoading) {
text = "processing...";
text = "Deleting...";
}

if (deleteResult.isSuccess) {
return <Redirect to={base}/>;
}

return (
<button onClick={() => deleteEmoji(id)} disabled={deleteResult.isLoading}>{text}</button>
<button className="danger" onClick={() => deleteEmoji(id)} disabled={deleteResult.isLoading}>{text}</button>
);
}
29 changes: 5 additions & 24 deletions web/source/settings/admin/emoji/new-emoji.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,9 @@

const Promise = require('bluebird');
const React = require("react");
const { matchSorter } = require("match-sorter");

const FakeToot = require("../../components/fake-toot");
const MutateButton = require("../../components/mutation-button");
const ComboBox = require("../../components/combo-box");

const {
useTextInput,
Expand All @@ -33,9 +31,9 @@ const {
} = require("../../components/form");

const query = require("../../lib/query");
const syncpipe = require('syncpipe');
const { CategorySelect } = require('./category-select');

module.exports = function NewEmojiForm({ emoji, emojiByCategory }) {
module.exports = function NewEmojiForm({ emoji }) {
const emojiCodes = React.useMemo(() => {
return new Set(emoji.map((e) => e.shortcode));
}, [emoji]);
Expand All @@ -57,21 +55,6 @@ module.exports = function NewEmojiForm({ emoji, emojiByCategory }) {

const [categoryState, resetCategory, { category }] = useComboBoxInput("category");

// data used by the ComboBox element to select an emoji category
const categoryItems = React.useMemo(() => {
return syncpipe(emojiByCategory, [
(_) => Object.keys(_), // just emoji category names
(_) => matchSorter(_, category), // sorted by complex algorithm
(_) => _.map((categoryName) => [ // map to input value, and selectable element with icon
categoryName,
<>
<img src={emojiByCategory[categoryName][0].static_url} aria-hidden="true"></img>
{categoryName}
</>
])
]);
}, [emojiByCategory, category]);

React.useEffect(() => {
if (shortcode.length == 0) {
if (image != undefined) {
Expand Down Expand Up @@ -152,11 +135,9 @@ module.exports = function NewEmojiForm({ emoji, emojiByCategory }) {
/>
</div>

<ComboBox
state={categoryState}
items={categoryItems}
label="Category"
placeHolder="e.g., reactions"
<CategorySelect
value={category}
categoryState={categoryState}
/>

<MutateButton text="Upload emoji" result={result} />
Expand Down

0 comments on commit 665d902

Please sign in to comment.