[chore] Fix a few possible cases of int truncation (#1207)

This fixes a couple of cases where due to int being platform dependent a value could get truncated if running on 32bits.
superseriousbusiness · Dec 4, 2022 · 847e7c7 · 847e7c7
1 parent bc917a4
commit 847e7c7
Show file tree

Hide file tree

Showing 9 changed files with 10 additions and 10 deletions.
diff --git a/internal/api/client/account/statuses.go b/internal/api/client/account/statuses.go
@@ -152,7 +152,7 @@ func (m *Module) AccountStatusesGETHandler(c *gin.Context) {
 	limit := 30
 	limitString := c.Query(LimitKey)
 	if limitString != "" {
-		i, err := strconv.ParseInt(limitString, 10, 64)
+		i, err := strconv.ParseInt(limitString, 10, 32)
 		if err != nil {
 			err := fmt.Errorf("error parsing %s: %s", LimitKey, err)
 			api.ErrorHandler(c, gtserror.NewErrorBadRequest(err, err.Error()), m.processor.InstanceGet)

diff --git a/internal/api/client/admin/emojisget.go b/internal/api/client/admin/emojisget.go
@@ -146,7 +146,7 @@ func (m *Module) EmojisGETHandler(c *gin.Context) {
 	limit := 50
 	limitString := c.Query(LimitKey)
 	if limitString != "" {
-		i, err := strconv.ParseInt(limitString, 10, 64)
+		i, err := strconv.ParseInt(limitString, 10, 32)
 		if err != nil {
 			err := fmt.Errorf("error parsing %s: %s", LimitKey, err)
 			api.ErrorHandler(c, gtserror.NewErrorBadRequest(err, err.Error()), m.processor.InstanceGet)

diff --git a/internal/api/client/blocks/blocksget.go b/internal/api/client/blocks/blocksget.go
@@ -120,7 +120,7 @@ func (m *Module) BlocksGETHandler(c *gin.Context) {
 	limit := 20
 	limitString := c.Query(LimitKey)
 	if limitString != "" {
-		i, err := strconv.ParseInt(limitString, 10, 64)
+		i, err := strconv.ParseInt(limitString, 10, 32)
 		if err != nil {
 			err := fmt.Errorf("error parsing %s: %s", LimitKey, err)
 			api.ErrorHandler(c, gtserror.NewErrorBadRequest(err, err.Error()), m.processor.InstanceGet)

diff --git a/internal/api/client/favourites/favouritesget.go b/internal/api/client/favourites/favouritesget.go
@@ -102,7 +102,7 @@ func (m *Module) FavouritesGETHandler(c *gin.Context) {
 	limit := 20
 	limitString := c.Query(LimitKey)
 	if limitString != "" {
-		i, err := strconv.ParseInt(limitString, 10, 64)
+		i, err := strconv.ParseInt(limitString, 10, 32)
 		if err != nil {
 			err := fmt.Errorf("error parsing %s: %s", LimitKey, err)
 			api.ErrorHandler(c, gtserror.NewErrorBadRequest(err, err.Error()), m.processor.InstanceGet)

diff --git a/internal/api/client/notification/notificationsget.go b/internal/api/client/notification/notificationsget.go
@@ -123,7 +123,7 @@ func (m *Module) NotificationsGETHandler(c *gin.Context) {
 	limit := 20
 	limitString := c.Query(LimitKey)
 	if limitString != "" {
-		i, err := strconv.ParseInt(limitString, 10, 64)
+		i, err := strconv.ParseInt(limitString, 10, 32)
 		if err != nil {
 			err := fmt.Errorf("error parsing %s: %s", LimitKey, err)
 			api.ErrorHandler(c, gtserror.NewErrorBadRequest(err, err.Error()), m.processor.InstanceGet)

diff --git a/internal/api/client/search/searchget.go b/internal/api/client/search/searchget.go
@@ -109,7 +109,7 @@ func (m *Module) SearchGETHandler(c *gin.Context) {
 	limit := 2
 	limitString := c.Query(LimitKey)
 	if limitString != "" {
-		i, err := strconv.ParseInt(limitString, 10, 64)
+		i, err := strconv.ParseInt(limitString, 10, 32)
 		if err != nil {
 			err := fmt.Errorf("error parsing %s: %s", LimitKey, err)
 			api.ErrorHandler(c, gtserror.NewErrorBadRequest(err, err.Error()), m.processor.InstanceGet)
@@ -127,7 +127,7 @@ func (m *Module) SearchGETHandler(c *gin.Context) {
 	offset := 0
 	offsetString := c.Query(OffsetKey)
 	if offsetString != "" {
-		i, err := strconv.ParseInt(offsetString, 10, 64)
+		i, err := strconv.ParseInt(offsetString, 10, 32)
 		if err != nil {
 			err := fmt.Errorf("error parsing %s: %s", OffsetKey, err)
 			api.ErrorHandler(c, gtserror.NewErrorBadRequest(err, err.Error()), m.processor.InstanceGet)

diff --git a/internal/api/client/timeline/home.go b/internal/api/client/timeline/home.go
@@ -142,7 +142,7 @@ func (m *Module) HomeTimelineGETHandler(c *gin.Context) {
 	limit := 20
 	limitString := c.Query(LimitKey)
 	if limitString != "" {
-		i, err := strconv.ParseInt(limitString, 10, 64)
+		i, err := strconv.ParseInt(limitString, 10, 32)
 		if err != nil {
 			err := fmt.Errorf("error parsing %s: %s", LimitKey, err)
 			api.ErrorHandler(c, gtserror.NewErrorBadRequest(err, err.Error()), m.processor.InstanceGet)

diff --git a/internal/api/client/timeline/public.go b/internal/api/client/timeline/public.go
@@ -153,7 +153,7 @@ func (m *Module) PublicTimelineGETHandler(c *gin.Context) {
 	limit := 20
 	limitString := c.Query(LimitKey)
 	if limitString != "" {
-		i, err := strconv.ParseInt(limitString, 10, 64)
+		i, err := strconv.ParseInt(limitString, 10, 32)
 		if err != nil {
 			err := fmt.Errorf("error parsing %s: %s", LimitKey, err)
 			api.ErrorHandler(c, gtserror.NewErrorBadRequest(err, err.Error()), m.processor.InstanceGet)

diff --git a/testrig/db.go b/testrig/db.go
@@ -83,7 +83,7 @@ func NewTestDB() db.DB {
 	}
 
 	if alternateDBPort := os.Getenv("GTS_DB_PORT"); alternateDBPort != "" {
-		port, err := strconv.ParseInt(alternateDBPort, 10, 64)
+		port, err := strconv.ParseUint(alternateDBPort, 10, 16)
 		if err != nil {
 			panic(err)
 		}