Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] [i18n] Consider number on pluralising the number of accounts on instance #2456

Closed
Ryuno-Ki opened this issue Dec 14, 2023 · 0 comments · Fixed by #2480
Closed

[bug] [i18n] Consider number on pluralising the number of accounts on instance #2456

Ryuno-Ki opened this issue Dec 14, 2023 · 0 comments · Fixed by #2480
Labels
bug Something isn't working frontend Frontend-related stuff

Comments

@Ryuno-Ki
Copy link

Describe the bug with a clear and concise description of what the bug is. Please include screenshots of any visual issues.

When I create my first account using the CLI and visit the landing page, GoToSocial claims that there is „1 users” on that instance.

https://github.com/superseriousbusiness/gotosocial/blob/v0.13.0-rc2/web/template/index.tmpl#L22

is the line to update.

What's your GoToSocial Version?

v0.13.0-rc2

Browser version

Firefox 115.0.2

What happened?

The template does not take into account the number on pluralisation.

What you expected to happen?

„There is 1 user”.

How to reproduce it?

Create a new GoToSocial instance and add admin account via CLI.
Then visit the landing page.

Anything else we need to know?

I've translated software in the past. This is one of the gotchas to watch out for. You're not the first project who fell for it and you won't be the last.

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/PluralRules has a high level description.

https://github.com/nicksnyder/go-i18n#go-i18n---- claims to support it.

@Ryuno-Ki Ryuno-Ki added bug Something isn't working frontend Frontend-related stuff labels Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend Frontend-related stuff
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant